search

nitnelave / CreeperHeal

24 stars 22 forks source link

Some Bugfixes regarding Skulls #51

Closed kronnox closed 7 years ago

kronnox commented 7 years ago

This should fix two bugs. On the one hand, that the owner of regenerated skulls is set correctly again. This does not happen at the moment because the method [Skull].getOwningPlayer.getName() always returns null, so that no owner can be assigned to the skull. On the other hand, that the SkullMeta was not transferred when skulls were dropped during regeneration.

used MC-Version: 1.12 used Spigot build: Spigot-596221b-9a1fc1e (API: 1.12-R0.1-SNAPSHOT)

nitnelave commented 7 years ago

Thanks a lot for the PR! Did you check that it fixed the issue?

kronnox commented 7 years ago

Just checked again, in my test environment* everything works now as it should. Skulls regenerate and drop in the proper state.

*[MC-1.12; Spigot-596221b-9a1fc1e (API: 1.12-R0.1-SNAPSHOT)]