search

nitnelave / CreeperHeal

24 stars 22 forks source link

Correctly drop own BlockState drops when breaking #63

Closed Jikoo closed 5 years ago

Jikoo commented 5 years ago

This PR fixes major dupe bugs related to incorrect blocks being dropped when using config options overwrite-blocks and drop-destroyed-blocks.

Still needs testing on 1.11/12, I just want to start discussion.

I'm worried that shulker boxes will suffer the same issues that other containers did - primary inventory required a somewhat hacky workaround to restore properly.

Per discussion in #61, I also need to revisit CreeperBlock#checkForDrop:

Remove this function, and turn the checkForDrop function in CreeperBlock static, it's the same.

It's not quite as simple as making it static - CreeperBlock#checkForDrop also calls CreeperBlock#drop conditionally.

Jikoo commented 5 years ago

Okay, I've tested this pretty thoroughly on 1.11 @nitnelave, #64 is also ready when you have the time.

nitnelave commented 5 years ago

Thanks a lot for the 2 PR!