search

nitnelave / hopper

Programming language
Other
2 stars 0 forks source link

Add logging and improve flags #41

Closed nitnelave closed 7 years ago

nitnelave commented 7 years ago

This PR adds a logging utility to facilitate development.

This change is Reviewable

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.9%) to 95.253% when pulling 19049b7d16469d1752a741950a6c4a456f5ec17e on logging into c38341798b16131e0fa63a35a1bf9c952f09fb07 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.152% when pulling 053f55f62a6f394ca49d1964128de6480d944d5c on logging into c38341798b16131e0fa63a35a1bf9c952f09fb07 on master.

bloody76 commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: 0 of 9 files reviewed at latest revision, 2 unresolved discussions.

src/util/logging.cc, line 9 at r1 (raw file):


// log(INFO) << "Just a joke";
// log_if(INFO, a > 3) << "Nothing much";

dead code or example?

src/util/logging.h, line 9 at r1 (raw file):

DECLARE_int32(verbosity);

enum Severity {

what about enum class ? I think we could go for it here

Comments from Reviewable

nitnelave commented 7 years ago

Review status: 0 of 9 files reviewed at latest revision, 2 unresolved discussions.

src/util/logging.cc, line 9 at r1 (raw file):

Previously, bloody76 (Bd76) wrote…
dead code or example?

Example. Probably should make it clearer, though.

src/util/logging.h, line 9 at r1 (raw file):

Previously, bloody76 (Bd76) wrote…
what about enum class ? I think we could go for it here

No, I don't want to have to write log(Severity::INFO) << "test";

Comments from Reviewable

bloody76 commented 7 years ago
:lgtm:

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

bloody76 commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r3. Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 1 of 1 files at r4. Review status: 1 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 3 of 3 files at r5. Review status: 1 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 3 of 3 files at r6. Review status: 2 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 3 of 3 files at r7. Review status: 5 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 2 of 3 files at r8, 2 of 3 files at r9. Review status: 8 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 1 of 3 files at r9. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.528% when pulling 5091f43b9b5f4556d2066d710febd7f6b15b0f8e on logging into a60aa1d02ade49934ef4c96de17becf1c60e6d43 on master.