add contribution guidelines

nitnelave / hopper

Programming language

Other

2 stars 0 forks source link

add contribution guidelines #43

Closed nitnelave closed 7 years ago

nitnelave commented 7 years ago

This change is

bloody76 commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

CONTRIBUTING.md, line 32 at r1 (raw file):

guide](https://google.github.io/styleguide/cppguide.html), but with slightly
different naming conventions. All types (except standard ones) are in
_CamelCase_, all functions and variables in _snake\_case_.

this is camelCase, this is PascalCase

CONTRIBUTING.md, line 48 at r1 (raw file):

- Make sure `make check` still passes.
- Create logically separated commits (more on that later).
- Write tests for your feature.

Normally it would be better to write tests for your feature first, then check that it indeed fails, then write code until it works

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

nitnelave commented 7 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

CONTRIBUTING.md, line 48 at r1 (raw file):

Previously, bloody76 (Bd76) wrote…

Normally it would be better to write tests for your feature first, then check that it indeed fails, then write code until it works

True, but they shouldn't be committed before the feature. Anyway, experienced coders know how to code, they don't need me.

Comments from Reviewable

nitnelave commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

CONTRIBUTING.md, line 32 at r1 (raw file):

Previously, bloody76 (Bd76) wrote…

this is camelCase, this is PascalCase

Done.

Comments from Reviewable

bloody76 commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

coveralls commented 7 years ago

Coverage remained the same at 98.528% when pulling 25761ec6b6746ab20d407c29087d1a3ff5bd17f1 on contribute into a60aa1d02ade49934ef4c96de17becf1c60e6d43 on master.