Sets declaration as statements

nitnelave / hopper

Programming language

Other

2 stars 0 forks source link

Sets declaration as statements #47

Closed bloody76 closed 7 years ago

bloody76 commented 7 years ago

This change is

coveralls commented 7 years ago

Coverage increased (+0.008%) to 98.536% when pulling 51730cb0d7fbf8c2f5b377bead3d6ca52ec939d0 on declaration_as_statement into a60aa1d02ade49934ef4c96de17becf1c60e6d43 on master.

nitnelave commented 7 years ago

add pretty-printer tests

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 97.914% when pulling 695e1f78156110d48afef51d70cb4e1f2c70ae1e on declaration_as_statement into d233c8f758da41926cb2b1a8b9bfd416291fe35b on master.

bloody76 commented 7 years ago

Pretty printer tests added, was worth it in the end because there was an issue with the printing of function declarations.

Comments from Reviewable

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 97.914% when pulling 55eef1a863f53f1115eb5ec2fa2ef53f6b2d3334 on declaration_as_statement into d233c8f758da41926cb2b1a8b9bfd416291fe35b on master.

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 97.914% when pulling 55eef1a863f53f1115eb5ec2fa2ef53f6b2d3334 on declaration_as_statement into d233c8f758da41926cb2b1a8b9bfd416291fe35b on master.

nitnelave commented 7 years ago

I noticed the bug on pretty printing, it's also fixed in my PR (typechecking) because it broke some tests. Can you export it to a new PR that I would quick-LGTM?

Review status: 3 of 7 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bloody76 commented 7 years ago

Ok will do.

Review status: 3 of 7 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

coveralls commented 7 years ago

Coverage increased (+0.01%) to 98.542% when pulling 6c212030c817d4468d0246bebbd3d90854a8f6a9 on declaration_as_statement into d233c8f758da41926cb2b1a8b9bfd416291fe35b on master.

coveralls commented 7 years ago

Coverage increased (+0.008%) to 98.542% when pulling c4fccbe95d77b059f7f2e590c56fa494b7ddc3aa on declaration_as_statement into 116f6f7ffdfb4d73a8d96a0f6b683282365fea36 on master.

coveralls commented 7 years ago

Coverage increased (+0.008%) to 98.387% when pulling 342260bddcaf0b79ed6f52ef5116da1388b1fc14 on declaration_as_statement into 1678e264d891f3c0e1f0ba95e11860b8a450a00b on master.

nitnelave commented 7 years ago

Review status: 2 of 6 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable