option: add specializations

nitnelave / hopper

Programming language

Other

2 stars 0 forks source link

option: add specializations #64

Open nitnelave opened 7 years ago

nitnelave commented 7 years ago

This change is

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.303% when pulling 8593c366385986fefe121d1c186f3f5b769e4ec1 on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.303% when pulling 8593c366385986fefe121d1c186f3f5b769e4ec1 on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

bloody76 commented 7 years ago

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

test/util/option.cc, line 12 at r1 (raw file):

  Option<VariantInt> op1 = none;
  op1 = 3;
  op1 = "test";

can you add a test with op1 = none ?

Comments from Reviewable

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.303% when pulling cca8512012a2d40e69b5b68527f9ad8216a02c0d on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

nitnelave commented 7 years ago

Review status: 2 of 4 files reviewed at latest revision, 1 unresolved discussion.

test/util/option.cc, line 12 at r1 (raw file):

Previously, bloody76 (Bd76) wrote…

can you add a test with op1 = none ?

Done!

Comments from Reviewable

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.307% when pulling b1b3d5870030e483da9281f9568975f310151cb0 on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.307% when pulling b1b3d5870030e483da9281f9568975f310151cb0 on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.307% when pulling 2851e4f60f62cd1906217314d735d07183357cba on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.307% when pulling 488c7437ff8fa7b1c232bff27b7c174487c22929 on option into 1dad241d4f7395507bece2fd9f82f71d5bc3279d on master.

bloody76 commented 7 years ago

Reviewed 3 of 3 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable