search

nitram2342 / bruteforce-crc

Brute-forcing CRC parameters
http://sitsec.net/blog/2012/02/10/brute-forcing-crc-parameters/
Boost Software License 1.0
65 stars 13 forks source link

Bug and conversion error when specifying `Initial` #4

Closed solomonbstoner closed 3 years ago

solomonbstoner commented 3 years ago

Two issues regarding specifying initial. I have already fixed and verified the issue on my computer. Will create a PR soon.

  1. When --initial is specified, a conversion error is thrown.

Screenshot from 2021-05-20 15-13-56

  1. After fixing issue 1, --probe-initial should be set to false by default. By setting it to true by default, even when the user specifies --initial, the program does not register it and goes ahead with bruteforcing possible initial values.
solomonbstoner commented 3 years ago

After applying PR #6 , the program gracefully accepts and uses the CRC seed of 106 given by --initial 106

Screenshot from 2021-05-20 15-00-40

nitram2342 commented 3 years ago

Thank you very much for fixing this issue!