Closed solomonbstoner closed 3 years ago
Consider the example below generated by the test case generator.
Under current master
code would print an extra 0x19
in the example implementation.
After applying #6 , the correct byte sequence is printed.
The code provided in the
Example implementation
output for found matches contains an extra last byte of the provided input bitstream (excluding the CRC).For example, consider the bitstream generated below.
Its hex equivalent is shown below. The non-CRC portions are highlighted. Notice that the LSB on the right is
0x90
.However, the
0x90
is repeated in the example implementation in the output when--verbose true
Its a pretty inconsequential bug so I wasnt compelled to fix it. I might open a PR for this after my working hours