nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: display disconnected dashboard alert with instructions #600

Closed davemooreuws closed 12 months ago

davemooreuws commented 1 year ago

adds instructions when application is disconnected from dashboard. Also adds a retry when start command has exited.

Includes a fix to include more browsers / expand open browser method. This was taken from the internal go stdlib

Looks like: image

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e7ff7d9) 31.22% compared to head (9752a4e) 31.22%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #600 +/- ## ======================================= Coverage 31.22% 31.22% ======================================= Files 29 29 Lines 1957 1957 ======================================= Hits 611 611 Misses 1307 1307 Partials 39 39 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `31.22% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HomelessDinosaur commented 1 year ago

Is this intentionally an overlay at the top instead of a block? Screen Shot 2023-11-24 at 9 59 10 am

davemooreuws commented 1 year ago

Is this intentionally an overlay at the top instead of a block?

Fixed

nitric-bot commented 12 months ago

:tada: This PR is included in version 1.33.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: