nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: remove pterm with tui #696

Closed davemooreuws closed 8 months ago

davemooreuws commented 8 months ago

On windows git bash and potentially other environments, pterm causes colors to break in the terminal output.

We shouldn't be mixing pterm with lipgloss/bubbletea. This PR replaces all pterm calls with a tui view.

Looks like this: image

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 1.33%. Comparing base (0632a8f) to head (f0d63e5). Report is 2 commits behind head on main.

Files Patch % Lines
pkg/view/tui/printer.go 0.00% 13 Missing :warning:
pkg/cloud/gateway/gateway.go 0.00% 5 Missing :warning:
pkg/update/update.go 0.00% 2 Missing :warning:
pkg/netx/freeport.go 0.00% 1 Missing :warning:
pkg/ports/ports.go 0.00% 1 Missing :warning:
pkg/view/tui/commands/stack/down/stack_down.go 0.00% 1 Missing :warning:
pkg/view/tui/errors.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #696 +/- ## ======================================== - Coverage 1.33% 1.33% -0.01% ======================================== Files 72 73 +1 Lines 7318 7342 +24 ======================================== Hits 98 98 - Misses 7215 7239 +24 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/696/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/696/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.33% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nitric-bot commented 8 months ago

:tada: This PR is included in version 1.36.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: