search

nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: filter out conflicting os vars #698

Closed davemooreuws closed 8 months ago

davemooreuws commented 8 months ago

apis are not being deployed correctly from windows due to conflicting os env vars being sent into the container. This could be an issue anywhere.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 1.34%. Comparing base (ae21790) to head (07122fd).

Files Patch % Lines
pkg/project/service.go 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #698 +/- ## ======================================== - Coverage 1.34% 1.34% -0.01% ======================================== Files 72 72 Lines 7260 7268 +8 ======================================== Hits 98 98 - Misses 7157 7165 +8 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/698/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/698/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.34% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HomelessDinosaur commented 8 months ago

If it's only a windows issue, should you only filter if windows is detected? Also maybe debug log which environment variables are being filtered out, might cause issues if a dev expects it to exist.

davemooreuws commented 8 months ago

If it's only a windows issue, should you only filter if windows is detected? Also maybe debug log which environment variables are being filtered out, might cause issues if a dev expects it to exist.

Could potentially happen on other platforms. Windows it just happens OOTB.

nitric-bot commented 8 months ago

:tada: This PR is included in version 1.35.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: