search

nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: add content-disposition #716

Closed jyecusch closed 7 months ago

jyecusch commented 7 months ago

Allows downloads using the signed download URL to set an appropriate name on the downloaded file.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 1.43%. Comparing base (c71a044) to head (4da05a9).

Files Patch % Lines
pkg/cloud/storage/storage.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #716 +/- ## ======================================== - Coverage 1.43% 1.43% -0.01% ======================================== Files 73 73 Lines 7479 7480 +1 ======================================== Hits 107 107 - Misses 7364 7365 +1 Partials 8 8 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/716/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/716/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.43% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nitric-bot commented 7 months ago

:tada: This PR is included in version 1.38.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: