search

nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: put double quotes around database name for local db create #734

Closed davemooreuws closed 5 months ago

davemooreuws commented 5 months ago

Allows hyphens to be added back in for local dev.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.30%. Comparing base (5352cd5) to head (a3e1177).

Files Patch % Lines
pkg/cloud/sql/sql.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #734 +/- ## ===================================== Coverage 1.29% 1.30% ===================================== Files 78 78 Lines 8231 8224 -7 ===================================== Hits 107 107 + Misses 8116 8109 -7 Partials 8 8 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/734/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/734/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.30% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nitric-bot commented 5 months ago

:tada: This PR is included in version 1.42.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: