search

nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: allow 'q' in text prompt component #740

Closed jyecusch closed 4 months ago

jyecusch commented 4 months ago

Consistently use 'esc' and 'ctrl+c' for quitting instead of the 'q' to avoid issues where names include a 'q' and cause commands to exit.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 1.29%. Comparing base (bdf443f) to head (1086e11).

Files Patch % Lines
pkg/view/tui/commands/services/run.go 0.00% 5 Missing :warning:
pkg/view/tui/commands/build/build.go 0.00% 2 Missing :warning:
pkg/view/tui/commands/local/run.go 0.00% 2 Missing :warning:
pkg/view/tui/commands/local/startup.go 0.00% 2 Missing :warning:
pkg/view/tui/commands/stack/down/stack_down.go 0.00% 2 Missing :warning:
pkg/view/tui/commands/stack/select/stack_select.go 0.00% 2 Missing :warning:
pkg/view/tui/commands/stack/up/stack_up.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #740 +/- ## ===================================== Coverage 1.29% 1.29% ===================================== Files 78 78 Lines 8244 8240 -4 ===================================== Hits 107 107 + Misses 8129 8125 -4 Partials 8 8 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/740/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/740/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.29% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nitric-bot commented 4 months ago

:tada: This PR is included in version 1.43.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: