fix: ensure custom runtime build args are not overwritten

davemooreuws commented 4 months ago

I found this bug by creating two services in golang with the custom runtime. The HANDLER arg was overwritten and all services got the same value, this fixes that.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 1.16%. Comparing base (c802f08) to head (fa4eded).

Files	Patch %	Lines
pkg/project/runtime/runtime.go	0.00%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #742 +/- ## ======================================== - Coverage 1.16% 1.16% -0.01% ======================================== Files 78 78 Lines 8246 8252 +6 ======================================== Hits 96 96 - Misses 8141 8147 +6 Partials 9 9 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/742/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/742/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.16% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nitric-bot commented 4 months ago

:tada: This PR is included in version 1.44.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

nitrictech / cli

fix: ensure custom runtime build args are not overwritten #742

Codecov Report