nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

feat: allow HTTPS for local APIs and Http Proxies #746

Closed jyecusch closed 4 months ago

jyecusch commented 4 months ago

Enabled using nitric start --https-preview

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 1.15%. Comparing base (922bd95) to head (cc659ce).

Files Patch % Lines
pkg/cloud/gateway/gateway.go 0.00% 49 Missing :warning:
pkg/dashboard/handlers.go 0.00% 18 Missing :warning:
pkg/paths/paths.go 0.00% 9 Missing :warning:
pkg/cloud/cloud.go 0.00% 8 Missing :warning:
pkg/view/tui/commands/local/run.go 0.00% 4 Missing :warning:
pkg/dashboard/dashboard.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #746 +/- ## ======================================== - Coverage 1.15% 1.15% -0.01% ======================================== Files 78 78 Lines 8292 8344 +52 ======================================== Hits 96 96 - Misses 8186 8238 +52 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/746/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `1.15% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davemooreuws commented 4 months ago

Looks good just one change.

nitric-bot commented 4 months ago

:tada: This PR is included in version 1.47.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: