nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

feat: Add basedir to service defintion #783

Closed tjholm closed 2 months ago

tjholm commented 2 months ago

If a custom runtime is specfied its "context" property will override basedir, if it is not blank, otherwise it will simply use basedir as context. basedir defaults to "" which is functionally identical to "."

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 24.48980% with 37 lines in your changes missing coverage. Please review.

Project coverage is 2.84%. Comparing base (b29a14f) to head (2e76f92). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/project/project.go 0.00% 18 Missing :warning:
pkg/project/service.go 0.00% 13 Missing :warning:
pkg/project/runtime/runtime.go 66.66% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #783 +/- ## ======================================== - Coverage 2.85% 2.84% -0.01% ======================================== Files 82 82 Lines 9122 9132 +10 ======================================== Hits 260 260 - Misses 8850 8860 +10 Partials 12 12 ``` | [Flag](https://app.codecov.io/gh/nitrictech/cli/pull/783/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nitrictech/cli/pull/783/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `2.84% <24.48%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nitric-bot commented 2 months ago

:tada: This PR is included in version 1.52.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: