nitrictech / cli

Nitric CLI. Manage and run Nitric apps locally and deploy to any cloud.
https://nitric.io
Apache License 2.0
26 stars 10 forks source link

fix: Add resource name validation to local run and collection #799

Closed tjholm closed 1 month ago

davemooreuws commented 1 month ago

@tjholm The errors show up nicely and it works well. However there is one scenario that forces the user to restart the start command.

Steps to reproduce (in the TS example):

  1. Change API to an invalid name
  2. Change to the suggested name
  3. As it refreshes you can see the API has not been registered correctly
tjholm commented 1 month ago

@tjholm The errors show up nicely and it works well. However there is one scenario that forces the user to restart the start command.

Steps to reproduce (in the TS example):

1. Change API to an invalid name

2. Change to the suggested name

3. As it refreshes you can see the API has not been registered correctly

Can you confirm this doesn't occur on 84240a3214f43a0553ecc86297eeb53d0076200c (I can reproduce it there).

If it's a separate regression we should fix it in a separate PR to keep the diffs minimal.

nitric-bot commented 1 month ago

:tada: This PR is included in version 1.54.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: