search

nitrictech / nitric

Nitric is a multi-language framework for cloud applications with infrastructure from code.
https://nitric.io
Apache License 2.0
1.09k stars 50 forks source link

feat: add custom tea lifecycle for up and down commands #544

Closed HomelessDinosaur closed 8 months ago

HomelessDinosaur commented 10 months ago

Closes https://github.com/nitrictech/nitric/issues/507

davemooreuws commented 10 months ago

@HomelessDinosaur

Should update pulumi with windows fix: https://github.com/pulumi/pulumi/pull/14659 when ready.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c00476) 57.28% compared to head (c8718cd) 57.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #544 +/- ## =========================================== - Coverage 57.28% 57.22% -0.06% =========================================== Files 54 54 Lines 5155 5155 =========================================== - Hits 2953 2950 -3 - Misses 2009 2012 +3 Partials 193 193 ``` | [Flag](https://app.codecov.io/gh/nitrictech/nitric/pull/544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | Coverage Δ | | |---|---|---| | [aws](https://app.codecov.io/gh/nitrictech/nitric/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `58.97% <ø> (ø)` | | | [azure](https://app.codecov.io/gh/nitrictech/nitric/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `61.61% <ø> (ø)` | | | [core](https://app.codecov.io/gh/nitrictech/nitric/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `60.73% <ø> (-0.17%)` | :arrow_down: | | [gcp](https://app.codecov.io/gh/nitrictech/nitric/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech) | `45.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nitrictech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tjholm commented 8 months ago

this has been addressed in v1 with new lifecycle events.