rmcl
commented
2 months ago @ninjha01 This is ready for you to take a look at.
Outright bugs in core logic
- only thing that I thought was a bit strange was the overlap of annotations of the same type on the LinearAnnotation component. Somehow either completely hiding overlapping or making it clear that there are multiple annotations would be nice. As I mentioned in the comment, for larger sequences with fewer overlaps this is less of a problem.
Performance bottlenecks
We've talked a fair bit about this mismatch code and displaying large sequences. Overall, it seems like the components are pretty simple and don't have many components that are dependent on the length of the sequences. I think you did a good job of calculating the size of the components based on the length of the sequences. Things do slow down a bit as the sequences get larger, but at least in the current stories a lot of that slowness is in the generation of the long sequence and less in the display / rendering of DOM elements.
Code Smells/Refactoring opportunities
I put a few comments throughout especially around more explicit definition of interfaces. There were also a few method names that were confusing and more descriptive comments would be good.
Styling Issues
Style is fairly tight throughout. I didn't see many style issues I'd object to so you and your IDE/linter are doing well
@rmcl is attempting to deploy a commit to the Nitro Bio Team on Vercel.
A member of the Team first needs to authorize it.