search

nitrofski / WSplit

43 stars 16 forks source link

Goal #2

Closed pnolin closed 9 years ago

nitrofski commented 9 years ago

I took a quick look at the modifications and they seem legit. The only thing that bothered me is how you put a space before the colon when you write the goal on the interface. (Correct english doesn't have a space before colons).

I unfortunately don't have Visual Studio on my computer anymore, so I cannot compile and run it... If possible, I'd like to see the result on all display modes before I merge (Detailed, Normal, Wide, etc.) May as well want to remove the spaces before the colons and add it to this pull request.

In any way, thanks for the contribution!

pnolin commented 9 years ago

detailednormalbackground detailedplainbackground wide widenogoal advanceddetail compact detailedblackbackground

Hi,

First of all thanks for the response. I took some picture with the goal. There is three picture with the detailed display (Normal, plain, and black). Two picture for wide display. With the goal I changed the position of the run status and without it its the same. For compact and advanced detail its a basic display.

I also took the time to change the colon.

Thanks.

nitrofski commented 9 years ago

Great, I'll merge ;)

If you are willing to put a bit more work into it, the normal display could probably be improved visually: be made more compact and, in the case of the "Gradient" display, have the 2-level gradient not repeating.