search

nitrogen / simple_bridge

A simple, standardized interface library to Erlang HTTP Servers.
MIT License
112 stars 76 forks source link

Update cowboy bridge for compatibility with newer versions of cowboy #22

Closed mgregson closed 11 years ago

choptastic commented 11 years ago

Hello Michael,

Thank you for the pull request. Cowboy 0.8 support will be merged in shortly, however @RomanShestakov beat you to the punch. The relevant commit can be found here: https://github.com/choptastic/simple_bridge/commit/78b87917e5d6efeed4f3c01bed0d23c736bfb8ca

This change also includes significantly improved static file handling to change it from the hack I originally made for the cowboy 0.6 support, which will something that will now use sendfile rather than loading entire static files into memory.

https://github.com/choptastic/simple_bridge/commit/4ab0342634a3e09c77a9da4f944efd0b2c3b52a3

I appreciate the pull request, though :)

Edit: Typo fix s/not/now/

mgregson commented 11 years ago

Awesome. Glad to hear it, and thanks for letting me know.