search

nitrogen / simple_bridge

A simple, standardized interface library to Erlang HTTP Servers.
MIT License
112 stars 76 forks source link

Introducing memory file upload handling #30

Closed metok closed 10 years ago

metok commented 10 years ago

This change introduces memory file upload handling and works nearly similar to django's file upload handler logic.

The memory file handler is the default file handler which holds the file in memory. When the maximum size (simple_bridge_max_file_in_memory_size) has reached the memory file handler switches to the temporary file handler that works as before for uploaded files.

It's possible to define custom file handlers. Setting the custom file handlers over configuration like django would be a nice addition. Conributions are welcome.

choptastic commented 10 years ago

Thanks so much Mehmet! This looks so neat.

As a convenience, do you think you could take the time to quickly update the readme with any kind of instructions related to this new handler system which you feel should be relayed to the programmer?

metok commented 10 years ago

Hi Jesse, sorry I forgot the Readme update. This should clarify what programmers can do with the change currently. I hope the Readme update is ok?

choptastic commented 10 years ago

That looks great, thank you. I'll do some testing of it today and assuming I don't run into any game breaking bugs, will merge today or tomorrow.

Thanks again,

-Jesse

Jesse Gumm Owner, Sigma Star Systems 414.940.4866 || sigma-star.com || @jessegumm On Oct 28, 2013 8:53 AM, "Mehmet Emin Tok" notifications@github.com wrote:

Hi Jesse, sorry I forgot the Readme update. Thishttps://github.com/synlay/simple_bridge/commit/a4c1645dc43dabe9a1f8a6ad6ce2d93f2634314dshould clarify what programmers can do with the change currently. I hope the Readme update is ok?

— Reply to this email directly or view it on GitHubhttps://github.com/nitrogen/simple_bridge/pull/30#issuecomment-27212870 .

choptastic commented 10 years ago

Thanks Mehmet! It's merged.

I'll let you know that I'm working on a new major version of Simple Bridge, and that I'll be making a few changes to this, in particular, all configuration for simple bridge will be moved into a standard environment variable rather than command line arguments. Obviously, you could still specify those command line arguments with -simple_bridge simple_bridge_max_file_in_memory_size 3, rather than using a config file, but the option is yours.

Anyway, I just wanted to give you that heads up, since I notice the use of command line arguments.