search

nitrogen / simple_bridge

A simple, standardized interface library to Erlang HTTP Servers.
MIT License
112 stars 76 forks source link

Update cowboy to v1.0.0 #38

Closed fooflare closed 9 years ago

fooflare commented 9 years ago

Hi Jesse, I've been testing cowboy v1.0.0 with Nitrogen project webpage and seems it works fine just with this little change. I make this pull request if you are interested in updating it now. If so, I have made the update too in my nitrogen fork, but I'll wait to pull request until you decide if you really want to change it in simple_bridge.

choptastic commented 9 years ago

So funny! This is also something I was working on last night. I'll merge in your changes here, but there are a few missing pieces (particularly with properly handling the fact that cowboy_req:stream_body was removed in Cowboy 1.0.

But I like it, and you did the mimetypes stuff, which I completely forgot about :)

choptastic commented 9 years ago

No need to update the PR or make the PR for Nitrogen. I have the deps updated locally, I'm just finishing the compatibility stuff and testing with file uploads, which should all be ready today to prepare another beta release.

fooflare commented 9 years ago

Oh, I think I'll have to ask before in the future :) I realized that there were some things I was missing, but as always late :( One thing I crashed with this PR was autocomplete textbox (again), I am not sure what changed in json from cowboy. I have a strange fight with this widget. I tried to fix it but the only thing I got was a headache.

choptastic commented 9 years ago

No need to ask, it's pretty rare to have this kind of collision.

The textbox_autocomplete is a little nasty, but I think it's made a little less so with the websocket update. Either way, I'll play with it.

Very likely, I'll end up reworking it in a non-backwards compatible way, since it is a little goofy, what with its reliance on json and whatnot.

-Jesse

On Wed, Oct 1, 2014 at 11:00 AM, fooflare notifications@github.com wrote:

Oh, I think I'll have to ask before in the future :) I realized that there were some things I was missing, but as always late :( One thing I crashed with this PR was autocomplete textbox (again), I am not sure what changed in json from cowboy. I have a strange fight with this widget. I tried to fix it but the only thing I got was a headache.

— Reply to this email directly or view it on GitHub https://github.com/nitrogen/simple_bridge/pull/38#issuecomment-57489161.

Jesse Gumm Owner, Sigma Star Systems 414.940.4866 || sigma-star.com || @jessegumm