search

nitrogen / simple_bridge

A simple, standardized interface library to Erlang HTTP Servers.
MIT License
112 stars 76 forks source link

YAWs Timeout and max file post size #51

Closed stuart-thackray closed 8 years ago

stuart-thackray commented 8 years ago

Hi Jesse,

This is for YAWS using embedded.

This is to allow the max file post size configured in the configuration; to be also applied to yaws otherwise yaws default limits apply; therefore with simple bridge configuration (max_post_size) is not effective at larger values.

Additionally am using the websocket timeout value to set the keepalive_timeout of YAWS. On slower connections you will not receive uploads due to the default of 30 seconds. Going through this I think in the future this should be a different configuration value.

Added some basic comments to explain there is configuration of websocket_interval and websocket_timeout

Regards, Stuart

choptastic commented 8 years ago

Thanks Stuart. I'm working through a few things on my side here, but will be merging this in. Also, I know about the Yaws 1.98 vs 2.00 but there are some confusing things with what's going on with Yaws as dependency that I've meant to ask the yaws devs about.

choptastic commented 8 years ago

Thanks again, this has been rebased to a single commit (for cleanliness) and merged (https://github.com/nitrogen/simple_bridge/commit/f64788d3bcd3554953be3c38831d9633fe7cee59)

choptastic commented 8 years ago

The rebased single commit that was used for the merger: https://github.com/nitrogen/simple_bridge/commit/aeca36e21f95b1471c4aa195dd150e65eab24d86

stuart-thackray commented 8 years ago

Thanks Jesse