search

nitrogen / simple_bridge

A simple, standardized interface library to Erlang HTTP Servers.
MIT License
112 stars 76 forks source link

About sendfile funs #68

Closed essen closed 5 years ago

essen commented 5 years ago

Sorry to pollute your ticket tracker but I can't seem to be able to send you an email, getting a DNS related error? Anyway here's what I wanted to say:

This area of Cowboy was modified because of HTTP/2. Cowboy can no longer give direct socket access and therefore the funs were removed. Instead, sendfile is now a tuple that can be given anywhere a body or body segment is expected (so there can be more than one).

choptastic commented 5 years ago

Thanks for the clarification, Loic! Appreciate the explanation. That makes sense with respect to the http2.

I'll work in a workaround.

Cheers, man!

I'm guessing the DNS error had to do with Google groups. It kinda sucks.

-Jesse

On Tue, Feb 19, 2019, 7:47 AM Loïc Hoguin notifications@github.com wrote:

Sorry to pollute your ticket tracker but I can't seem to be able to send you an email, getting a DNS related error? Anyway here's what I wanted to say:

This area of Cowboy was modified because of HTTP/2. Cowboy can no longer give direct socket access and therefore the funs were removed. Instead, sendfile is now a tuple that can be given anywhere a body or body segment is expected (so there can be more than one).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nitrogen/simple_bridge/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/AALYnJ7xxuqgJfdhpgtgIGkX0gO6XkBhks5vPABjgaJpZM4bC__L .

essen commented 5 years ago

Cheers.