search

nitroshare / nitroshare-desktop

Network file transfer application for Windows, OS X, & Linux
http://nitroshare.net
MIT License
1.57k stars 223 forks source link

Wrong installation pathes for breeze and breeze-dark icons #80

Open rapgro opened 8 years ago

rapgro commented 8 years ago

The path "breeze-dark/apps/22/nitroshare-indicator.svg" looks wrong to me. Better use "breeze-dark/scalable/apps/nitroshare-indicator.svg" Analogously for breeze instead of breeze-dark.

rapgro commented 8 years ago

Fix with this script:

mkdir -p src/dist/icons/breeze-dark/scalable src/dist/icons/breeze/scalable mv src/dist/icons/breeze-dark/apps/22 src/dist/icons/breeze-dark/scalable/apps mv src/dist/icons/breeze/apps/22 src/dist/icons/breeze/scalable/apps rm -rfv src/dist/icons/breeze*/apps

nathan-osman commented 8 years ago

No, this icons are labeled correctly. The "breeze" icons are shown on a light background and must use a dark color to stand out from the background. Conversely, the "breeze-dark" icons are shown on a dark background and must show a light color to stand out.

rapgro commented 8 years ago

I think you missed the point. It's not about removing the icons, it's about a wrong directory they get installed to. Your directory structure is against XDG standard. https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout

nathan-osman commented 8 years ago

Oh, I'm sorry. I misunderstood what you were saying. I'll take a look at this tomorrow.

rapgro commented 8 years ago

not addressed in 0.3.3

abitrolly commented 6 years ago

Is that still actual? @rapgro maybe send a patch?

rapgro commented 6 years ago

not addressed in 0.3.4 https://src.fedoraproject.org/rpms/nitroshare/blob/master/f/nitroshare.spec#_107 @abitrolly Look above for the patch.

abitrolly commented 6 years ago

@rapgro send it here - https://github.com/nitroshare/nitroshare-desktop/pulls