search

nitroshare / qhttpengine

HTTP server for Qt applications
MIT License
159 stars 76 forks source link

Range request and partial content support #10

Closed Kuraisu closed 8 years ago

Kuraisu commented 8 years ago

Hi,

This pull request contains implementation of HTTP ranges (RFC 2616, RFC 7233) and additions to QFilesystemHandler and QIODeviceCopier to support partial content requests. Although this implementation lacks multipart reply support, it already allows to stream video/audio content with seeking support and allows resuming on interrupted downloads. Additionally, unit tests are implemented for all new features.

Please review this pull request and help me find a best way to merge it (after the review). Should it be merged to new-features or to master?

Regards, Aleksei

nathan-osman commented 8 years ago

Oh wow, thanks! I was planning to implement this eventually and now you've saved me a lot of time. I'll take care of the merge.

Kuraisu commented 8 years ago

Glad to help. QHttpEngine is a nice library with great test coverage. If you'll have any questions about implementation, I'll be glad to answer.

nathan-osman commented 8 years ago

Merge is complete. Thanks again!