search

nittolese / gquestions

Find "People Also Ask" questions
GNU General Public License v3.0
59 stars 36 forks source link

MAX_DEPTH=1? #5

Closed danyaljj closed 5 years ago

danyaljj commented 5 years ago

Looks like the maximum depth one can set is 1: https://github.com/nittolese/gquestions/blob/master/gquestions.py#L300-L305

What is the logic here?

nittolese commented 5 years ago

Hi @danyaljj , thanks for asking. That piece of code is a bit messy right now, but don't worry: it's on the top of my to-do list for this repo.

When depth=0 -> It clicks only on first 3-4 questions and create this tree graph When depth=1 -> It clicks on question 1 (level1), then it clicks on the question appeared after the click on question 1 (level2) and gathers info about the last question appeared (level3). The tree graph generated is something like this.

It should be: When depth=0 -> Don't click on anything. Create a tree graph without any interaction with questions (so you should see only the first 3-4 questions). When depth=1 -> It clicks only on first 3-4 questions and create the tree graph. When depth=2 -> Same behavior as current depth=1 .

MAX_DEPTH=1 is only a constant to validate the CLI args. Feel free to contribute with a PR :)