niu-gdo / IGDO-Fall-2023-Project

IGDO's Fall 2023 game project.
7 stars 0 forks source link

Isolation of Character Controller #37

Closed ExplosiveEggshells closed 10 months ago

ExplosiveEggshells commented 10 months ago

Summary

The introduction of these changes will resolve #35 , doing the following:

There is no functional change to the game with this PR, but it addresses a dangerous issue of shoving everything into one "PlayerController" script- moving towards isolating functionality into separate "modules" is a big bonus for clarity, readability, and modularity.

Conflicts

Note, this PR will cause merge conflicts with other in-progress branches that use the character controller.

ExplosiveEggshells commented 10 months ago

Let's see if we can get this reviewed and pushed in ASAP, we'd like to have this issue fixed so that people will see how to make new modules for player behavior (rather than shoving more functionality into the controller). It will also break some branches when pulled into main, so ASAP is ideal.

Migs commented 10 months ago

Comments on the functions would be nice, otherwise LGTM. I will merge, but create an issue to add comments to it.