search

niv / nwn-lib

Neverwinter Nights 1/2 file formats ruby library
http://rubydoc.info/github/niv/nwn-lib/
Other
17 stars 4 forks source link

Fixnum deprecated in Ruby 2.4 #8

Closed jakkn closed 7 years ago

jakkn commented 7 years ago

Fixnum is used in three places and is producing deprecated warnings. Especially visible when running nwn-gff on multiple files without silenced warnings.

/home/jakob/.gem/ruby/2.4.0/gems/nwn-lib-0.6.0/lib/nwn/gff/field.rb:172: warning: constant ::Fixnum is deprecated
/home/jakob/.gem/ruby/2.4.0/gems/nwn-lib-0.6.0/lib/nwn/gff/field.rb:172: warning: constant ::Fixnum is deprecated
/home/jakob/.gem/ruby/2.4.0/gems/nwn-lib-0.6.0/lib/nwn/gff/field.rb:172: warning: constant ::Fixnum is deprecated
niv commented 7 years ago

Thanks for the report. Seems it works fine otherwise in 2.4.

I've pushed a fix (duh) but it's not on the gem mirrors yet - need to roll a release with all the other commits/fixes that went in meanwhile.

jakkn commented 7 years ago

Gem updated to 0.6.1 with no difference in output and warnings gone.

Thanks niv, good stuff!