niv / websocket.nim

websockets for nim
http://niv.github.io/websocket.nim/docs/0.1.1/websocket.html
Other
101 stars 25 forks source link

How does `when NimMinor < 18:` work in post-1.0 Nim? #67

Closed narimiran closed 4 years ago

narimiran commented 4 years ago

I've just skimmed through the code, and I noticed this line, and (without trying) it seems to me it does wrong thing for Nim versions after v1.0.

I think that line should be:

when (NimMajor, NimMinor) < (0, 18):