search

niw / HapticKey

A simple utility application to trigger haptic feedback when tapping Touch Bar.
MIT License
1.65k stars 62 forks source link

Feature Request: Option for Volume Control on Sound Feed Back #30

Open rbdej opened 5 years ago

rbdej commented 5 years ago

Hi, I like the app and have been using it for quite some time now (about 2 or 3 weeks) and I just realised that a Volume control for the Sound Feedback option could be a great addition.

Thank you so much for the great app :)

niw commented 5 years ago

@rbdej Let me think about this, that feature could be improved for sure.

rbdej commented 5 years ago

Ok, thank you for responding back. Keep up the great work on the app :)

wrabit commented 4 years ago

Would be good to see this

niw commented 4 years ago

Here, 523bade, I made an experimental change to add volume control.

There is no user interface to change it for now. Therefore you need to use defaults(1) to control it like defaults write at.niw.HapticKey SoundEffectVolume -float 0.3.

Since only user interface currently HapticKey has is status item menu, which can provide very limited user interactions for changing preferences. It was enough for the original features, but time by time, by adding more, it is getting difficult to add many preferences on it.

It may take while to add new preferences user interface so, I posted this patch for now.

amkaplan commented 4 years ago

Speaking as someone who doesn't code, I'm putting in a vote for a volume control if it's feasible, whenever it's feasible.

I can, however follow instructions, if someone is game to provide them.

Many thanks

dylan-cm commented 3 years ago

I just want to chime in a second this. Functionality that would be the bees knees would be as you slide you feel clicks as if the slider as little notches.

Love the work you've done so far. Cheers.