search

niw / HapticKey

A simple utility application to trigger haptic feedback when tapping Touch Bar.
MIT License
1.65k stars 62 forks source link

Added Korean localization #49

Closed HyeongminKim closed 3 years ago

HyeongminKim commented 3 years ago

I am sending a PR with Korean localization.

스크린샷 2021-04-01 18 53 34
niw commented 3 years ago

@HyeongminKim Thank you for the translation! I will check the wording consistency with Apple’s glossary shortly and merge this.

HyeongminKim commented 3 years ago

  1. The string you suggested is missing investigation, but it shouldn't be a problem as anyone can understand it.

  2. Sure

  3. "깜빡임"1 doesn't look bad in my opinion, but I'll leave it to your choice. (However, I will attach a screenshot of “Flash the screen when an alert sound occurs” in the Audio section located in the Accessibility of System Preferences.)

    스크린샷 2021-04-28 20 03 54

  4. I think "HapticKey를 메뉴바에 보이기" would be better.

ps

  1. In order to avoid confusion, I will attach the tedious grammar because the strings in the system configuration and the strings uploaded to GitHub are different. Both “깜빡하다” and “깜박하다” were recognized as correct expressions by the National Institute of the Korean Language. (References can be found here (Korean).)
niw commented 3 years ago

Appreciate for your feedback.

  1. The string you suggested is missing investigation, but it shouldn't be a problem as anyone can understand it.

If it’s not common wording, then ignore my suggestion. To be honest, I found that wording in apps that is using Sparkle or a similar update mechanism, but really not sure if that’s common wording in the macOS apps or not.

  1. "깜빡임"1 doesn't look bad in my opinion, but I'll leave it to your choice. (However, I will attach a screenshot of “Flash the screen when an alert sound occurs” in the Audio section located in the Accessibility of System Preferences.) 스크린샷 2021-04-28 20 03 54

Ah, I see! Nice finding in Accessibility preferences pane. Let’s keep it as-is.

  1. I think "HapticKey를 메뉴바에 보이기" would be better.

OK, thanks! Let’s keep it as-is.

niw commented 3 years ago

Since my suggestion is really minor, I merged your current change and update it later on master. Thank you!