10 keep vector column info

niwa / geoapis

A Python package for simply downloading publicly available web-hosted geo-spatial data. View API docs at: https://niwa.github.io/geoapis/

MIT License

9 stars 3 forks source link

10 keep vector column info #11

Closed rosepearson closed 3 years ago

rosepearson commented 3 years ago

Extend geoapis.vector LINZ to also record all the 'properties' information associated with each vector in a column for each property in the geopandas.GeoDataFrame

[x] Update geoapis.vector to pull out the 'properties' information
[x] Update the tests to ensure the properties columns are added
[x] Update the tests to ensure the values of one of the properties columns is as expected

rosepearson commented 3 years ago

Hi @Pooja3894 do you mind having a quick review of this PR. I think a quick code review is sufficient, but you are welcome to test more thoroughly.

rosepearson commented 3 years ago

just a minor change in a comment (line number 90) might be required. Otherwise, Great work @rosepearson

Thanks @Pooja3894 - good suggestion. Hopefully it is a little clearer now!