8 vector linz class extension

niwa / geoapis

A Python package for simply downloading publicly available web-hosted geo-spatial data. View API docs at: https://niwa.github.io/geoapis/

MIT License

9 stars 3 forks source link

8 vector linz class extension #12

Closed rosepearson closed 2 years ago

rosepearson commented 2 years ago

Clean up the vector.Linz class before using it as a template for downloading vector data from LRIS.

Changes:

[X] Allow the class to be used to download all features in a layer if no search polygon is specified
[x] Try default the LINZ 'geometry_names' in turn if no 'geometry_name' is specified
[X] Add a test for downloading all feature values (i.e. no search polygon)
[X] Add a test for not specifying the 'geometry_name' - add to existing test.

rosepearson commented 2 years ago

Hi @Pooja3894 this PR contains changes to the vector.Linz class that I would like to make before I use the Linz class as the starting point for a new Lris class for downloading from LRIS. I think a code review is probably sufficient + checking that I have added enough new tests to maintain test coverage