15 traceback no features in bounds

niwa / geoapis

A Python package for simply downloading publicly available web-hosted geo-spatial data. View API docs at: https://niwa.github.io/geoapis/

MIT License

9 stars 3 forks source link

15 traceback no features in bounds #16

Closed rosepearson closed 2 years ago

rosepearson commented 2 years ago

Bug fix - changes to eliminate the trace back when no vector features are within the specified WFS BBox:

[X] Make code change
[x] Update tests
- [x] Update / create new tests
- [x] Ensure these tests have the expected behavour
- [X] Test locally and ensure tests are passing
[x] Ensure tests passing on GH Actions
[X] Update documentation
- [X] Doc strings
- [X] Wiki

rosepearson commented 2 years ago

@Pooja3894 or @LukeParky this is ready for a review. I've tested it locally and using GH actions. I think a quick code review is all that is needed. It addresses a trace-back that was occurring if no features of a vector layer were in bounds.

rosepearson commented 2 years ago

Changes look clear, tests pass. I like that the new test appears to cover the traceback

Thanks @LukeParky! I'll merge it in now then :)