niwa / geoapis

A Python package for simply downloading publicly available web-hosted geo-spatial data. View API docs at: https://niwa.github.io/geoapis/
MIT License
9 stars 3 forks source link

Add progress bar, change file_prefix to file_name & fix minor bug #35

Closed LukeParky closed 1 year ago

LukeParky commented 1 year ago

DESCRIPTION OF PR: I have not yet tested how this works when the progress bar is written to a log file. So I will be testing that.

Each commit fixes a different problem so feel free to only cherry-pick what you would like. None of these issues are super important but I was using this as an exercise to understand GeoAPIs better.

ADDS tqdm DEPENDENCY

LukeParky commented 1 year ago

Resetting to draft because I believe that the progress bar interferes with logging to files.

rosepearson commented 1 year ago

Nice @LukeParky . I'm in Dunedin next week with a conference and won't have a chance to look at this prior to that. If that works for you, we can wait till then. If you need this functionality before then I'm happy for you to land on this fork and we can sort out cherry picking later.

rosepearson commented 1 year ago

Hmm come general comments I made which seem to have been lost: