search

niwa / geoapis

A Python package for simply downloading publicly available web-hosted geo-spatial data. View API docs at: https://niwa.github.io/geoapis/
MIT License
9 stars 3 forks source link

1 separate geoapis from geofabrics #4

Closed rosepearson closed 2 years ago

rosepearson commented 2 years ago

Separate out the lidar_fetch and vector_fetch capabilities with tests running.

  1. Separate code
  2. Ensure tests are running each push
  3. Ensure tests are running locally
  4. Updated README
rosepearson commented 2 years ago

Hi @Pooja3894 - I think this initial port is ready to be reviewed and merged into master. We can discuss any other functionality we want the library to have before we publish it to PyPI tomorrow when I'm in the office.

Do you mind giving it a quick code review? I've attached screenshots of the tests passing. test_lidar_fetch.py image test_vector_fetch image

Pooja3894 commented 2 years ago

Hi @Pooja3894 - I think this initial port is ready to be reviewed and merged into master. We can discuss any other functionality we want the library to have before we publish it to PyPI tomorrow when I'm in the office.

Do you mind giving it a quick code review? I've attached screenshots of the tests passing. test_lidar_fetch.py image test_vector_fetch image

Pooja3894 commented 2 years ago

code is running. clearly defined functions. Great work @rosepearson