niwadhwa / bugzilla-vcs

Automatically exported from code.google.com/p/bugzilla-vcs
0 stars 0 forks source link

Ability to remove commits from a bug #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Need to be able to remove commits from a bug, as it's possible somebody typo'd 
a bug # in his/her commit, which linked it to the wrong bug.

Original issue reported on code.google.com by reed%ree...@gtempaccount.com on 29 Aug 2010 at 10:16

GoogleCodeExporter commented 9 years ago

Original comment by avatrax...@gmail.com on 2 Sep 2010 at 8:22

GoogleCodeExporter commented 9 years ago
Hi, it's reasonable request.

Attached patch adds 'delete' option like following;
hook.pl --delete --bug=<BUG#> --revision=<REVISION#> 
--login=<BUGZILLA_USERNAME> --pass=<BUGZILLA_PASSWORD> 
--bugzilla=<URL_TO_BUGZILLA>

Go to extension directory (may be in /usr/share/bugzilla/extensions/VCS) and do;
patch -p0 -i <PATCHFILE>

Please note that I am just a stranger not bugzilla-vcs guys;)

Best Regards,
kohirohi.

Original comment by kohir...@gmail.com on 15 Feb 2011 at 9:02

Attachments:

GoogleCodeExporter commented 9 years ago
Hey, that's great, thank you! I think what was wanted was a way to delete this 
in the UI, though. What we'd want to do is implement remove_from_db for a 
Commit object, and then do something with the template_before_page hook to 
allow it to be deleted.

Original comment by avatrax...@gmail.com on 15 Feb 2011 at 2:17

GoogleCodeExporter commented 9 years ago
Hi, I did shorten Commit.delete by using remove_from_db as you mentioned. Also 
I tried that put a delete button in each commit but I stacked at where we have 
to xml-rpc call from JavaScript. Anyway, an interface to delete function have 
been placed in the patch. So call it please ;)

Thanks,
kohirohi.

Original comment by kohir...@gmail.com on 17 Feb 2011 at 4:22

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Removed some potions and adjusted.(Wrong files for this issue and relative 
path).
- Shorten Commit.delete

Original comment by kohir...@gmail.com on 17 Feb 2011 at 12:06

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch.

modified hook.pl
modified lib/Commit.pm
modified lib/WebService.pm
modified template/en/default/hook/global/user-error-errors.html.tmpl
Committed revision 26.                                                         

Original comment by sgreen%redhat.com@gtempaccount.com on 13 Dec 2013 at 11:47