niwadhwa / bugzilla-vcs

Automatically exported from code.google.com/p/bugzilla-vcs
0 stars 0 forks source link

Revision number is not clickable in bug-detail screen #8

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. started with a clean system, installed VCS
2. called sync.pl which ran through and I can see the VCS panel in bug details 
for certain bugs

What is the expected output? What do you see instead?
I would have expected and I actually see this in the screenshot available here 
that the revision number in the VCS web panel in clickable which will link you 
too a loggerhead/viewvc or whatever software to see the revision details.
This is not the case. Instead the Revision is just a plain string, no link.

What version of the product are you using? On what operating system?
0.2.0 on openSUSE 11.1, Bzr 2.2.1, Loggerhead 1.18

Original issue reported on code.google.com by manfb...@gmail.com on 17 Nov 2010 at 7:23

GoogleCodeExporter commented 9 years ago
Thanks! Could you give me the exact contents of your two vcs_* parameters?

Original comment by avatrax...@gmail.com on 17 Nov 2010 at 8:25

GoogleCodeExporter commented 9 years ago
vcs_repos: Bzr bzr+ssh://<host>/srv/bzr
vcs_web: bzr+ssh://<host>/srv/bzr 
https://<host>/loggerhead/%project%/revision/%revno%

<host> is to be replaced with the real hostname but I don't want to publish 
this here.

Original comment by manfb...@gmail.com on 18 Nov 2010 at 9:25

GoogleCodeExporter commented 9 years ago
Using Bugzilla 4.0
1.
vcs_repos: Svn file:///var/svn/repositories/project_name

vcs_web: file:///var/svn/repositories/project_name 
http://192.168.2.9/viewvc/project_name?view=revision&revision=%revno%

2. Clicking anywhere inside the (-)expanded commit area, (+)collapses it 
immediately.
   Can't even select any text there (for copying).
   Code: <li onclick="toggleCommitDetails(18)" id="vcs_commit_row_18" class="vcs_commit_row vcs_expanded_item">
   I guess ondoubleclick would be more appropriate.

3. Using http:// or https:// in vcs_repos does not work either.

Original comment by indivarn...@gmail.com on 10 Mar 2011 at 10:22

GoogleCodeExporter commented 9 years ago
Okay, thanks for letting me know! I will look into this as soon as I have the 
chance. I've noticed the problem with +/- as well.

Original comment by avatrax...@gmail.com on 14 Mar 2011 at 10:01

GoogleCodeExporter commented 9 years ago
Hello everyone.
As an computer scientist with NULL knowledge about Perl i just put some dirty 
"prints" into the Extension.pm to check the "equals"-expression.

If you enter the following text into the vcs_repo field: Svn 
file:///var/svn/repositories/project_name

and into the vcs_web field : file:///var/svn/repositories/project_name 
http://192.168.2.9/viewvc/project_name?view=revision&revision=%revno%

the Expression would check the following strings :
file:///var/svn/repositories/project_name/ == 
file:///var/svn/repositories/project_name 

As you can see a "/" is missing.
By giving an additional slash at the End of the Path/URL in the vcs_web field 
the Code is working and the linkage is shown.

for example ...

vcs_repo : Svn file:///var/svn/repositories/project_name
vcs_web : file:///var/svn/repositories/project_name/ 
http://192.168.2.9/viewvc/project_name?view=revision&revision=%revno%

will probably work.
Sorry for my bad English! :)

I hope this will help users as well as the programmers of bugzilla-vcs ...

Original comment by Wunderwo...@web.de on 3 Jun 2011 at 11:42

GoogleCodeExporter commented 9 years ago
Thanks WunderwolfX.
It Works perfectly.

Noticed that the example text does show a '/' at the end. But as generally most 
us would do, I just copied the vcs_repo text to vcs_web and added the URL part.

It could probably be highlighted in the example text.

:-)

Original comment by indivarn...@gmail.com on 5 Jun 2011 at 8:21

GoogleCodeExporter commented 9 years ago
Ah, thank you Wunderwolf! I should make the system accept both URLs ending in a 
/ and not ending in a /.

Original comment by mka...@google.com on 6 Jun 2011 at 11:37