search

niwinz / django-jinja

Simple and nonobstructive jinja2 integration with Django.
http://niwinz.github.io/django-jinja/latest/
BSD 3-Clause "New" or "Revised" License
363 stars 102 forks source link

2.3.1 breaks public `Template` interface #204

Closed currycoder closed 6 years ago

currycoder commented 7 years ago

This commit https://github.com/niwinz/django-jinja/commit/406333ce589e91debcd3a1db3f79de9cabf76524 has made it so that the Template object no longer has a template attribute. This is a compatibility breaking change for libraries that assume it to be present - the public interface for Template objects is now changed.

I'm not really sure what a solution could be for this. From what I understand, the code exhibiting the problem is in django's IncludeNode. So, this is covering the case where a django template includes a jinja template?

niwinz commented 7 years ago

I will revert that change!

niwinz commented 6 years ago

Already reverted