search

niwinz / django-jinja

Simple and nonobstructive jinja2 integration with Django.
http://niwinz.github.io/django-jinja/latest/
BSD 3-Clause "New" or "Revised" License
363 stars 102 forks source link

explicit version support in docs, changelog, test matrix #248

Closed wizpig64 closed 4 years ago

wizpig64 commented 4 years ago

django 3.0 dropped support for python 3.5, so the expanded tests here might fail. fingers crossed.

wizpig64 commented 4 years ago

That didn't go as well as I thought. Despite the merged commit f209e6b saying so, Django 3.0 compatibility is not yet achieved. I'll do some more work either fixing compat with 3.0. Or, if that's not feasible without dropping support for 1.11, I'll just amend this PR to remove the django-3 assurance.

wizpig64 commented 4 years ago

Alright, test coverage with django 3 was fixed by changing the test code (it was importing django.shortcuts.render_to_response, which was deprecated long ago). No user-imported code was changed, so it's still safe to call django-jinja 2.5.0 as-released compatible with django 3.0.

wizpig64 commented 4 years ago

Thanks @auvipy :)

auvipy commented 4 years ago

2.6 released!