makemessages does not detect trimmed trans blocks

[canassa]

Hello,

When I execute the makemessages command, it seems to be unable to detect trans tags that have the trimmed option in it. e.g.:

{% trans trimmed %}
  #{{ invoice_count }} invoice
{% pluralize %}
  #{{ invoice_count }} invoices
{% endtrans %}

If I remove the trimmed it works:

{% trans trimmed %}
  #{{ invoice_count }} invoice
{% pluralize %}
  #{{ invoice_count }} invoices
{% endtrans %}

[wizpig64]

I'm working on a change to get this to work, but tests are showing my regex-fu is coming up short. I'll let you know if I can get this working.

[wizpig64]

@canassa actually, i got the test suite's i18n template working, as well as makemessages to output.

It appears that, at least for this example, {% trans %} and {% trans trimmed %} blocks both get scanned correctly:

• template input: https://github.com/wizpig64/django-jinja/blob/twofivefive-worksforme/testing/testapp/templates/i18n_test.jinja#L32
• makemessages output: https://github.com/wizpig64/django-jinja/blob/twofivefive-worksforme/testing/locale/en/LC_MESSAGES/django.po#L68

Do you have any other insight into your real world example that could make it not work?

[canassa]

Hmm, that's weird, I can reproduce the error even with your test template. I pasted your i18n_test.jinja in my project and it didn't generate the trimmed messages. Could it be due to some configuration on my project?

[canassa]

Note: the problem happens even without the plularize:

<p>
{% trans %}
  trans test
{% endtrans %}
</p>

</p>
{% trans trimmed %}
  trans test trimmed
{% endtrans %}
</p>

[canassa]

I did another test and I found out that it generates the message if I set the tag to {% trans trimmed=1 %} instead of {% trans trimmed %} (but the message is generated untrimmed of course)

[wizpig64]

I pushed a regex change in 95e1f9 that relaxes the key=value bit. It doesn't change anything in my template test. Can you install that branch and let me know if it fixes it for you?

pip install -e git+https://github.com/wizpig64/django-jinja.git@95e1f91af7d28771e8f2ec90592bb64430903bd2#egg=django_jinja

[canassa]

Thanks! I will try it tonight and I let you know!

[wizpig64]

@canassa were you able to verify that the above branch fixed your {% trans trimmed %} block issues? I'd like to submit a pull request with the changes, if they indeed fixed makemessages, before the next django-jinja release.

Thanks for your time.

[canassa]

Hey!

Sorry! I ended up forgetting to reply to you 😞

I tested the following scenarios:

{% trans %}
  teste 123
{% endtrans %}

{% trans trimmed=1 %}
  teste 123
{% endtrans %}

{% trans trimmed %}
  teste 123
{% endtrans %}

All are being detected now! And {% trans trimmed %} is correctly trimming the string.

Thanks!

[wizpig64]

That's alright, thanks for your help!