search

nix-community / NUR

Nix User Repository: User contributed nix packages [maintainer=@Mic92]
https://nur.nix-community.org/
MIT License
1.26k stars 333 forks source link

Size limits on repos? #133

Open dtzWill opened 5 years ago

dtzWill commented 5 years ago

I was wondering why nur-combined was so big, turns out there's a 30+ gif in someone's repo! :laughing:

Well, that'd do it. But perhaps the update checker should consider such binary assets similar to a failing evaluation? Problem is deciding how big is too big...

And sorry to name names but the repo is @Ma27's-- @Ma27 is there a good alternative approach/location for storing the demo.gif that doesn't bundle it with your expressions?

I don't think it's catastrophically bad, and mostly impacts anyone curious about that repo or using nur-combined. Questions above are more about ensuring there's not some multi-gigabyte beast in the future.

Mic92 commented 5 years ago

Oh boi. Yeah, we should have a size limit.

Mic92 commented 5 years ago

also related to https://github.com/nix-community/NUR/pull/132

Mic92 commented 5 years ago

Maybe we can do a size limit per file also?

Mic92 commented 5 years ago

I also thought about excluding large repositories from being included in nur-combined.

makefu commented 5 years ago

for my repo i do a subdirectory-filter with git filter-branch to avoid exporting all my systems config,modules,libs and tests ( https://git.shackspace.de/krebs/stockholm/blob/master/.gitlab-ci.yml#L15 ).

Ma27 commented 5 years ago

And sorry to name names but the repo is @Ma27's-- @Ma27 is there a good alternative approach/location for storing the demo.gif that doesn't bundle it with your expressions?

That's perfectly fine, in the end you're absolutely right, that was a pretty bad idea :/

I have to admit that I currently don't use the NUR mechanism as I figured some time ago that simply using nix.nixPath and import <nixexprs> { /* ... */ } suits better for my workflow. As it isn't the first time I got pinged due to some problem with my repository I guess that it's the best for everyone if I remove my repo from NUR for now.

Mic92 commented 5 years ago

I suppose we would need a history rewrite to undo this.

yurrriq commented 5 years ago

Looks like the build has been broken since #134. Is there a fix planned?

yurrriq commented 5 years ago

:tada: https://travis-ci.com/nix-community/NUR/builds/112879185