search

nix-community / buildbot-nix

A nixos module to make buildbot a proper Nix-CI [maintainer=@Mic92]
64 stars 18 forks source link

Fix typo, secretKeyFile is a path not a string #200

Open Erethon opened 4 days ago

Erethon commented 4 days ago

Minor documentation fix after the recent GitHub App changes

Mic92 commented 3 days ago

Does it not accept strings at all? We actually want that to not import secrets into the nix store.

MagicRB commented 3 days ago

It ahould not be a path, if anything we should deny that in the module.

Erethon commented 3 days ago

Does it not accept strings at all? We actually want that to not import secrets into the nix store.

After 83849e86f87a7f550e3f3fc2a5f284d90f7662e3 I don't think it accepts strings, I got:

error: A definition for option `services.buildbot-nix.master.github.authType.app.secretKeyFile' is not of type `null or path'.

earlier when trying to pass a string (of the path).

Mic92 commented 3 days ago

What does your string looks like? This is what I have set:

nix-repl> nixosConfigurations.eve.config.services.buildbot-nix.master.github.authType.app.secretKeyFile
"/run/secrets/buildbot-github-app-secret-key"

It's by the way the same as for all other secret option. The string needs to contain an absolute path.