search

nix-community / bundix

Generates a Nix expression for your Bundler-managed application. [maintainer=@manveru]
163 stars 55 forks source link

Add redirection support #107

Closed nathantalewis closed 11 months ago

nathantalewis commented 1 year ago

Fixes #106

This PR adds support for HTTPRedirection responses from servers that use CDNs, like Github private package repositories

The tests could be a lot cleaner if we were to use a library or framework to mock the HTTP requests and responses instead of running our own fake server.

robbevp commented 1 year ago

Just bumped into this issue as well. It would be great to get this moved forward

robsears commented 12 months ago

@manveru Any chance this could get a review and merge? Running into the issue as well.

Mic92 commented 11 months ago

Code looks good to me and even has tests for the fixed issue. I would go ahead and merge this in a bit if there are no objections.