search

nix-community / bundix

Generates a Nix expression for your Bundler-managed application. [maintainer=@manveru]
163 stars 55 forks source link

Dropping --leave-dotGit breaks nix-bundle-install #60

Open peterhoeg opened 5 years ago

peterhoeg commented 5 years ago

51 has broken things when pointing at git repository in the Gemfile.

# Gemfile
gem 'sensu-plugins-ipmi', git: 'https://github.com/sensu-plugins/sensu-plugins-ipmi', branch: 'master'

The problem is that nix-bundle-install expects the .git directory to exist when building from a git checkout and therefore fails when it is missing.

The problem is that since we are specifying a revision (either a branch, tag or actual commit id), nix-bundle-install needs a proper repo in order to do a proper checkout of the correct revision.

Reverting #51, deleting gemset.nix for the gem in question and running bundix makes everything work again.

bflyblue commented 4 years ago

I'm having the same issue, any chance of getting this looked at? If someone can explain the right solution I can try do the actual work. Do we need to revert #51 or update nix-bundle-install to not expect the .git directory?

peterhoeg commented 4 years ago

I'm having the same issue, any chance of getting this looked at? If

Simply reverting it makes it work again. We apply that patch against bundix in nixpkgs which makes it all good. Of course it just means that it works fine for us.....