search

nix-community / comma

Comma runs software without installing it. [maintainers=@Artturin,@burke,@DavHau]
1.09k stars 48 forks source link

Update Cargo version #35

Closed cherryblossom000 closed 1 year ago

cherryblossom000 commented 2 years ago

This PR updates the version in Cargo.toml to 1.3.0, which will also ensure , --version gives the correct output

lilyinstarlight commented 1 year ago

Just a quick note related to this PR, the version test on the comma package in nixpkgs fails because the version was not updated in Cargo.toml

Output of nix -vL build --no-link nixpkgs#comma.tests.version ``` this derivation will be built: /nix/store/y46aa66i8xdvdg5zdzkzm04x5anjg9lc-comma-1.3.0-test-version.drv building '/nix/store/y46aa66i8xdvdg5zdzkzm04x5anjg9lc-comma-1.3.0-test-version.drv'... comma> Version string '1.3.0' not found! comma> The output was: comma> comma 1.2.3 error: builder for '/nix/store/y46aa66i8xdvdg5zdzkzm04x5anjg9lc-comma-1.3.0-test-version.drv' failed with exit code 1; last 3 log lines: > Version string '1.3.0' not found! > The output was: > comma 1.2.3 For full logs, run 'nix log /nix/store/y46aa66i8xdvdg5zdzkzm04x5anjg9lc-comma-1.3.0-test-version.drv'. ```
Artturin commented 1 year ago

fixed in https://github.com/nix-community/comma/releases/tag/v1.3.1