WIP: add support for veloren in tools.nix

nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix

https://nix-community.github.io/crate2nix/

Apache License 2.0

374 stars 89 forks source link

Closed marius851000 closed 3 years ago

marius851000 commented 3 years ago

This is my WIP work to be able to automatically generate the Cargo.nix for veloren via the tools.nix. The following change were made:

allow fetching workspace git depencies
allow to download git dependancies without an sha256 (that was work I did a long time ago, and don't remember exactly how it work, but it does)

What remain to do:

figure why num-literal is compiled without num-bigint, so failing the compilation of num that expect num-literal to be compiled with num-bigint (if you can help with that. That seems to be an issue with dynamic feature resolution).

kolloch commented 3 years ago

Heyo @marius851000,

I am, unfortunately, time constrained.

So, can you pleasse elaborate? What is the intent of each change? How does it work?

E.g. if you allow git references without sha, what is supposed to happen? Prefetch, determine sha? When is it supposed to happen?

What are workspace git dependencies? I see some string constants in the code and it is hard for me to judge if they are right.

Maybe also the following would help: Add any usage changes to README.md. Add code comments to explain things.

kolloch commented 3 years ago

Heyo, I am closing this for now, I hope that's fine.